Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bigquery job object to get_job #1844

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

LarsKlingen
Copy link
Contributor

What this PR does / why we need it:
Fixes Issue 1842 of job_id not found when querying bigquery job status from outside of US.

Which issue(s) this PR fixes:

Fixes #1842

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @LarsKlingen. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #1844 (a368616) into master (0dc13f0) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1844      +/-   ##
==========================================
- Coverage   84.45%   84.45%   -0.01%     
==========================================
  Files          90       90              
  Lines        6773     6772       -1     
==========================================
- Hits         5720     5719       -1     
  Misses       1053     1053              
Flag Coverage Δ
integrationtests 84.37% <71.42%> (-0.01%) ⬇️
unittests 63.74% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 81.94% <71.42%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc13f0...a368616. Read the comment docs.

@LarsKlingen
Copy link
Contributor Author

/assign @felixwang9817

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, LarsKlingen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Sep 8, 2021

Thanks for the PR @LarsKlingen !

@achals achals added kind/bug and removed needs-kind labels Sep 8, 2021
@feast-ci-bot feast-ci-bot merged commit 52085a3 into feast-dev:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigquery job id is not found in locations outside of US
5 participants