Add flags file to include experimental flags and test/usage flags #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
reviewed
Sep 15, 2021
woop
reviewed
Sep 15, 2021
sdk/python/feast/errors.py
Outdated
| class ExperimentalFeatureNotEnabled(Exception): | ||
| def __init__(self, feature_flag_name: str): | ||
| super().__init__( | ||
| f"Trying to use experimental feature. Please ensure to set environment variables {FLAG_ALPHA_FEATURES_NAME} and {feature_flag_name} to true" |
There was a problem hiding this comment.
What about
Suggested change
| f"Trying to use experimental feature. Please ensure to set environment variables {FLAG_ALPHA_FEATURES_NAME} and {feature_flag_name} to true" | |
| f"You are attempting to use an experimental feature. Please set the environment variables {FLAG_ALPHA_FEATURES_NAME} and {feature_flag_name} to true" |
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
- Coverage 84.75% 83.99% -0.77%
==========================================
Files 92 95 +3
Lines 7241 7383 +142
==========================================
+ Hits 6137 6201 +64
- Misses 1104 1182 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woop
reviewed
Sep 15, 2021
|
/retest |
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
adchia
force-pushed
the
experiment_flag
branch
from
626e56f
to
58303b7
Compare
achals
reviewed
Sep 16, 2021
Signed-off-by: Danny Chiao <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a flags module + puts python feature server & on demand transform behind that flag (throwing errors if not enabled). This uses feature_store.yaml as the way for users to control features, but provides cli methods to enable/disable features. Features are off by default (but on for tests)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: