Read registry & config from env variables in AWS Lambda feature server #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsotne Tabidze <[email protected]>
tsotnet
requested review from
achals,
adchia,
woop and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1870 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 92 92
Lines 7241 7241
=======================================
Hits 6137 6137
Misses 1104 1104
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze [email protected]
What this PR does / why we need it: We want to read registry (binary) and config (feature_store.yaml) via base64-encoded environment variables. They'll be set during
feast applywhen deploying AWS Lambda resource.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: