Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload docker image to ECR during feast apply #1877

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Sep 17, 2021

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: This PR pulls the AWS Lambda feature server docker image and uploads it to AWS ECR during feast apply.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

During feast apply, a feature server docker image may be uploaded to AWS ECR

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #1877 (5f70464) into master (2fccf76) will decrease coverage by 0.41%.
The diff coverage is 22.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
- Coverage   83.73%   83.31%   -0.42%     
==========================================
  Files          96       96              
  Lines        7353     7482     +129     
==========================================
+ Hits         6157     6234      +77     
- Misses       1196     1248      +52     
Flag Coverage Δ
integrationtests 74.19% <22.64%> (-0.26%) ⬇️
unittests 61.78% <18.86%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/aws.py 51.48% <9.52%> (-30.19%) ⬇️
sdk/python/feast/infra/passthrough_provider.py 96.00% <50.00%> (-4.00%) ⬇️
sdk/python/feast/errors.py 70.31% <66.66%> (-0.09%) ⬇️
sdk/python/feast/constants.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/provider.py 90.67% <100.00%> (+0.24%) ⬆️
sdk/python/feast/online_response.py 86.79% <0.00%> (-8.21%) ⬇️
sdk/python/feast/feature.py 74.24% <0.00%> (-0.76%) ⬇️
...n/feature_repos/universal/data_sources/bigquery.py 97.61% <0.00%> (-0.06%) ⬇️
sdk/python/tests/data/data_creator.py 100.00% <0.00%> (ø)
sdk/python/tests/utils/data_source_utils.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fccf76...5f70464. Read the comment docs.

sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/repo_operations.py Outdated Show resolved Hide resolved
Signed-off-by: Felix Wang <[email protected]>
Copy link
Collaborator

@tsotnet tsotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,tsotnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817 felixwang9817 added the kind/feature New feature or request label Sep 22, 2021
@feast-ci-bot feast-ci-bot merged commit 09f525c into feast-dev:master Sep 22, 2021
@felixwang9817 felixwang9817 deleted the docker_image_to_ecr branch September 22, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants