-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload docker image to ECR during feast apply #1877
Upload docker image to ECR during feast apply #1877
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 83.73% 83.31% -0.42%
==========================================
Files 96 96
Lines 7353 7482 +129
==========================================
+ Hits 6157 6234 +77
- Misses 1196 1248 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Felix Wang <[email protected]>
641efdc
to
294ad10
Compare
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang [email protected]
What this PR does / why we need it: This PR pulls the AWS Lambda feature server docker image and uploads it to AWS ECR during feast apply.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: