Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on demand feature view experimental docs #1880

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 17, 2021

What this PR does / why we need it:
Adds some experimental tags to on demand feature view related docs. Also including it in autogenerated python reference.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

…n Reference. Add to docs rst

Signed-off-by: Danny Chiao <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #1880 (3917403) into master (8a49a65) will decrease coverage by 21.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1880       +/-   ##
===========================================
- Coverage   83.96%   62.35%   -21.62%     
===========================================
  Files          95       96        +1     
  Lines        7392     7316       -76     
===========================================
- Hits         6207     4562     -1645     
- Misses       1185     2754     +1569     
Flag Coverage Δ
integrationtests ?
unittests 62.35% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 39.27% <ø> (ø)
sdk/python/feast/on_demand_feature_view.py 33.03% <ø> (-56.25%) ⬇️
.../integration/online_store/test_universal_online.py 14.73% <0.00%> (-85.27%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...fline_store/test_universal_historical_retrieval.py 18.69% <0.00%> (-80.49%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...istration/test_universal_odfv_feature_inference.py 35.71% <0.00%> (-64.29%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 30.32% <0.00%> (-63.12%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 30.35% <0.00%> (-62.50%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a49a65...3917403. Read the comment docs.

@adchia adchia merged commit e695457 into feast-dev:master Sep 19, 2021
@adchia adchia deleted the docs branch September 19, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants