Respect specified ValueTypes for features during materialization

[Agent007]

What this PR does / why we need it:
Float features are erroneously materialized to online stores as doubles. This bug could drastically affect the memory and storage usage of online stores.

Which issue(s) this PR fixes:

Fixes #1904

Does this PR introduce a user-facing change?:

NONE

[feast-ci-bot]

Hi @Agent007. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Agent007]

/kind bug

[Agent007]

@judahrand , you may be interested in this pull request since you've been working on cleaning up type conversions.

[achals]

@Agent007 I've updated this PR with what I think is a more general fix. Thanks for your contribution! If it looks good after tests, i'll merge it in today.

[codecov-commenter]

Codecov Report

Merging #1906 (badcdf8) into master (0342aa4) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
- Coverage   83.05%   82.83%   -0.22%     
==========================================
  Files          96       96              
  Lines        7317     7360      +43     
==========================================
+ Hits         6077     6097      +20     
- Misses       1240     1263      +23     

Flag	Coverage Δ
integrationtests	74.60% <66.66%> (-0.21%)	⬇️
unittests	60.65% <44.44%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/type_map.py	72.59% <100.00%> (-8.89%)	⬇️
...n/tests/integration/online_store/test_e2e_local.py	100.00% <100.00%> (ø)
.../integration/online_store/test_universal_online.py	100.00% <100.00%> (ø)
sdk/python/feast/repo_operations.py	42.46% <0.00%> (-1.76%)	⬇️
sdk/python/tests/unit/test_entity.py	100.00% <0.00%> (ø)
sdk/python/feast/feature_store.py	93.80% <0.00%> (+0.01%)	⬆️
sdk/python/feast/feature_view.py	86.92% <0.00%> (+0.35%)	⬆️
sdk/python/feast/on_demand_feature_view.py	89.65% <0.00%> (+0.36%)	⬆️
sdk/python/feast/entity.py	74.80% <0.00%> (+0.81%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0342aa4...badcdf8. Read the comment docs.

[Agent007]

@achals Thanks!

[achals]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, Agent007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment