-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve environment variables in repo config #1909
Conversation
Hi @samuel100. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: Sam Kemp <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1909 +/- ##
===========================================
+ Coverage 60.60% 83.05% +22.44%
===========================================
Files 96 96
Lines 7316 7317 +1
===========================================
+ Hits 4434 6077 +1643
+ Misses 2882 1240 -1642
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, samuel100 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The feature_store.yaml file allows Feast users to enter connection strings for offline and online stores. For example:
This means that a connection string can sit in a plain text file, which makes CI/CD impossible.
This PR allows Feast users to hide the connection string in the YAML file by using environment variables. For example:
Here the environment variable
CONN_STRING_ENV_VAR
is resolved in repo_config.load_repo_config method. This aids CI/CD flows (e.g. using secrets in GitHub actions).Does this PR introduce a user-facing change?: