Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makefile to use pip installed dependencies #1920

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

loftiskg
Copy link
Contributor

@loftiskg loftiskg commented Oct 1, 2021

What this PR does / why we need it:
First-time contributor here. I noticed that when I was running through the list of things in CONTRIBUTORS.md to set up my dev environment, I ran make lint and make format and a whole bunch of files were changes. Turns out that the black being used in my local setup was not the same the version of the one installed with dev dependencies. Since black is called directly as a CLI command rather than as a python module in the make command, it uses my system default rather than the one installed via pip install -e 'sdk/python[ci]'. This would also apply to the other python linting tools utilized in the make file as well (ie mypy, isort, etc). So to ensure that the correct versions of everything are used I changed the makefile to execute black and other python installed CLI tools as python modules.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @loftiskg. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #1920 (29b93a8) into master (0155284) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1920   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files          96       96           
  Lines        7376     7376           
=======================================
  Hits         6120     6120           
  Misses       1256     1256           
Flag Coverage Δ
integrationtests 74.41% <ø> (ø)
unittests 60.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0155284...29b93a8. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the fix @loftiskg !

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, loftiskg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator

/kind bug

@feast-ci-bot feast-ci-bot merged commit f31ea81 into feast-dev:master Oct 2, 2021
@loftiskg loftiskg deleted the update-makefile branch October 2, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants