-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify BigQuery load jobs #1935
Conversation
Hi @judahrand. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
:lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Sorry @adchia - realised we should also be requiring PyArrow>=4.0.0 |
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
===========================================
- Coverage 81.89% 59.36% -22.54%
===========================================
Files 97 97
Lines 7756 7739 -17
===========================================
- Hits 6352 4594 -1758
- Misses 1404 3145 +1741
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/ok-to-test |
/lgtm |
/lgtm |
@judahrand looks like this is ready to land barring a merge conflict - let us know if you need any help! |
@achals Should be sorted! |
Signed-off-by: Judah Rand <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
@achals Failure doesn't look like my fault |
/lgtm |
* Simplify BigQuery load jobs Signed-off-by: Judah Rand <[email protected]> * Ensure `pyarrow` supports `use_compliant_nested_type` Signed-off-by: Judah Rand <[email protected]>
What this PR does / why we need it:
A few weeks ago I contributed #1889 which fixed
ARRAY
columns in BigQuery. However, it added a fairly ugly workaround. I've fixed this upstream and it is available in the latest release ofgoogle-cloud-bigquery
: googleapis/python-bigquery#980.I thought it would make sense to simplify this in Feast by using the latest version.
Does this PR introduce a user-facing change?: