-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the BQ dataset in the location specified in feature_store.yaml if the dataset doesn't exists #1959
Conversation
Hi @francoisserra. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #1959 +/- ##
==========================================
- Coverage 83.61% 83.31% -0.31%
==========================================
Files 100 100
Lines 8080 8077 -3
==========================================
- Hits 6756 6729 -27
- Misses 1324 1348 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for the PR @francoisserra! Note that a PR can't be merged in unless all of the commits are signed ( |
ecf0381
to
0cc37a7
Compare
0cc37a7
to
d9659ae
Compare
@felixwang9817 : done ! I've signed my commit & force pushed it. Rgds, François |
Thanks @francoisserra. We're currently having some issues with our lint test. Once we fix that, I'll merge in your PR. |
Hey @francoisserra, we just fixed the issue with the linter that's been blocking all PRs for the last two days. Would you mind rebasing your changes on |
Signed-off-by: François Serra <[email protected]>
d9659ae
to
a26d0e0
Compare
@felixwang9817 : rebase & force push done. Sorry for the delay. Rgds François |
/lgtm |
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817, francoisserra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1958
Does this PR introduce a user-facing change?: