Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the BQ dataset in the location specified in feature_store.yaml if the dataset doesn't exists #1959

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

francoisserra
Copy link
Contributor

@francoisserra francoisserra commented Oct 21, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1958

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @francoisserra. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adchia
Copy link
Collaborator

adchia commented Oct 21, 2021

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #1959 (dfa591a) into master (019552e) will decrease coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1959      +/-   ##
==========================================
- Coverage   83.61%   83.31%   -0.31%     
==========================================
  Files         100      100              
  Lines        8080     8077       -3     
==========================================
- Hits         6756     6729      -27     
- Misses       1324     1348      +24     
Flag Coverage Δ
integrationtests 73.73% <100.00%> (-0.31%) ⬇️
unittests 58.21% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 81.39% <100.00%> (ø)
sdk/python/feast/infra/aws.py 72.59% <0.00%> (-11.06%) ⬇️
sdk/python/feast/inference.py 87.50% <0.00%> (-2.30%) ⬇️
.../integration/online_store/test_universal_online.py 97.67% <0.00%> (-0.47%) ⬇️
sdk/python/feast/feature_store.py 90.22% <0.00%> (-0.20%) ⬇️
sdk/python/feast/feature.py 72.72% <0.00%> (ø)
...n/tests/integration/registration/test_inference.py 100.00% <0.00%> (ø)
...sts/integration/registration/test_feature_store.py 99.31% <0.00%> (+<0.01%) ⬆️
sdk/python/feast/feature_view.py 89.28% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019552e...dfa591a. Read the comment docs.

@felixwang9817
Copy link
Collaborator

Thanks for the PR @francoisserra! Note that a PR can't be merged in unless all of the commits are signed (git commit -s); would you mind going back and signing your commit, and then force pushing it?

@francoisserra
Copy link
Contributor Author

@felixwang9817 : done ! I've signed my commit & force pushed it. Rgds, François

@felixwang9817
Copy link
Collaborator

Thanks @francoisserra. We're currently having some issues with our lint test. Once we fix that, I'll merge in your PR.

@adchia adchia changed the title fixes #1958 Create the BQ dataset in the location specified in feature_store.yaml if the dataset doesn't exists Oct 22, 2021
@felixwang9817
Copy link
Collaborator

Hey @francoisserra, we just fixed the issue with the linter that's been blocking all PRs for the last two days. Would you mind rebasing your changes on master and then force pushing your changes up? Thanks!

Signed-off-by: François Serra <[email protected]>
@francoisserra
Copy link
Contributor Author

@felixwang9817 : rebase & force push done. Sorry for the delay. Rgds François

@adchia
Copy link
Collaborator

adchia commented Nov 4, 2021

/lgtm

Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817, francoisserra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 73af2fa into feast-dev:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset location harcoded to US when using BigQueryOfflineStore.get_historical_features()
6 participants