-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plugin repos to actually overwrite repo configs #1966
Allow plugin repos to actually overwrite repo configs #1966
Conversation
Signed-off-by: Felix Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1966 +/- ##
==========================================
+ Coverage 81.97% 81.99% +0.01%
==========================================
Files 99 100 +1
Lines 7922 7925 +3
==========================================
+ Hits 6494 6498 +4
+ Misses 1428 1427 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sdk/python/tests/integration/feature_repos/repo_configuration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Felix Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
Signed-off-by: Felix Wang [email protected]
What this PR does / why we need it: This PR fixes a previous mistake which prevented plugin repos from actually overwriting repo configs.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: