Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin repos to actually overwrite repo configs #1966

Merged
merged 2 commits into from
Oct 23, 2021

Conversation

felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: This PR fixes a previous mistake which prevented plugin repos from actually overwriting repo configs.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2021

Codecov Report

Merging #1966 (b844236) into master (3b5ea8f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
+ Coverage   81.97%   81.99%   +0.01%     
==========================================
  Files          99      100       +1     
  Lines        7922     7925       +3     
==========================================
+ Hits         6494     6498       +4     
+ Misses       1428     1427       -1     
Flag Coverage Δ
integrationtests 74.31% <ø> (+0.02%) ⬆️
unittests 59.54% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 93.58% <ø> (+0.40%) ⬆️
...tion/feature_repos/integration_test_repo_config.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5ea8f...b844236. Read the comment docs.

Signed-off-by: Felix Wang <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator Author

/kind bug

@feast-ci-bot feast-ci-bot merged commit a3e18f6 into feast-dev:master Oct 23, 2021
@felixwang9817 felixwang9817 deleted the fix_plugin_testing branch October 23, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants