Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of _convert_arrow_to_proto #1984

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Improve performance of _convert_arrow_to_proto #1984

merged 1 commit into from
Oct 28, 2021

Commits on Oct 28, 2021

  1. Improve performance of _convert_arrow_to_proto 

    _convert_arrow_to_proto does multiple lookups in the list of column
names for the arrow table to find the index of columns. This is done for
each row so the time complexity grows quickly.
Rather than search the list of names for the index we construct a
dictionary {column_name: index}. This allows faster lookups for the
index of a column and speeds up the method significantly which affects
e.g. materialization.

Signed-off-by: Gunnar Sv Sigurbjörnsson <[email protected]>
    @nossrannug
    nossrannug committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    1165d87 View commit details
    Browse the repository at this point in the history