Fix protobuf version conflict in [gcp] and [ci] packages

[ysk24ok]

Signed-off-by: Yusuke Nishioka [email protected]

What this PR does / why we need it:

proto-plus==1.19.7 requires protobuf>=3.19.0, which conflicts with the version required by google-api-core[grpc].
Also, setup_requires tries to install the latest version of mypy-protobuf because the version is not specified and it requires protobuf>=3.18.0.
The error log is like this:

$ pipenv install -e "sdk/python[gcp]"
...
There are incompatible versions in the resolved dependencies:
  protobuf>=3.10 (from -r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 21))
  protobuf<3.18.0,>=3.12.0 (from google-api-core[grpc]==1.31.3->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 5))
  protobuf<4.0dev,>=3.5.0.post1 (from grpcio-tools==1.34.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 13))
  protobuf>=3.12.0 (from google-cloud-bigquery==2.29.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 26))
  protobuf>=3.18.0 (from mypy-protobuf==3.0.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 3))
  protobuf>=3.19.0 (from proto-plus==1.19.7->google-cloud-bigquery==2.29.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 26))
  protobuf>=3.6.0 (from googleapis-common-protos==1.52.0->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 25))
  protobuf>=3.6.0 (from grpcio-reflection==1.41.1->-r /tmp/pipenvu4bjkllirequirements/pipenv-sxv104g1-constraints.txt (line 14))

So I've fixed proto-plus version to <1.19.7 in [gcp] and [ci] packages, and mypy-protobuf in setup_requires to ==1.*.

We can check the installation succeeds by pipenv install -e "sdk/python[gcp]" and pipenv install -e "sdk/python[ci]"

Which issue(s) this PR fixes:

refs #1912 (comment)

IMO, closing #1912 should be done after the new version is released and we confirms that the installation succeeds.

Does this PR introduce a user-facing change?:

NONE

[feast-ci-bot]

Hi @ysk24ok. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #1992 (049999e) into master (bc4ffa5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1992   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files         101      101           
  Lines        8074     8074           
=======================================
  Hits         6633     6633           
  Misses       1441     1441           

Flag	Coverage Δ
integrationtests	74.62% <ø> (ø)
unittests	58.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc4ffa5...049999e. Read the comment docs.

[MattDelac]

I can confirm that those are already the versions we install today

[MattDelac]

While those comments are really useful in the PR, it should be removed in the code

[ysk24ok]

Deleted by 42d6f6f.

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MattDelac, ysk24ok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MattDelac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment