Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where using some Pandas dtypes in the output of an ODFV fails #1994

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Nov 4, 2021

What this PR does / why we need it:

  • When the DataFrame returned by an ODFV UDF uses dtypes like pd.Int64Dtype() type mapping fails.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@feast-ci-bot
Copy link
Collaborator

@judahrand: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #1994 (61b84fd) into master (704c247) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1994      +/-   ##
==========================================
+ Coverage   81.97%   82.00%   +0.03%     
==========================================
  Files          99      101       +2     
  Lines        7922     8108     +186     
==========================================
+ Hits         6494     6649     +155     
- Misses       1428     1459      +31     
Flag Coverage Δ
integrationtests 74.36% <100.00%> (+0.07%) ⬆️
unittests 58.86% <25.00%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/type_map.py 72.59% <100.00%> (ø)
...tegration/feature_repos/universal/feature_views.py 97.29% <100.00%> (+0.07%) ⬆️
...fline_store/test_universal_historical_retrieval.py 99.41% <100.00%> (+<0.01%) ⬆️
...istration/test_universal_odfv_feature_inference.py 100.00% <100.00%> (ø)
sdk/python/feast/feature_store.py 88.00% <0.00%> (-3.34%) ⬇️
sdk/python/feast/infra/online_stores/sqlite.py 96.51% <0.00%> (-2.33%) ⬇️
sdk/python/feast/infra/provider.py 89.43% <0.00%> (-0.57%) ⬇️
sdk/python/feast/infra/aws.py 39.26% <0.00%> (-0.41%) ⬇️
sdk/python/feast/cli.py 38.21% <0.00%> (-0.30%) ⬇️
sdk/python/feast/flags.py 100.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704c247...61b84fd. Read the comment docs.

@judahrand
Copy link
Member Author

Can I have an ok-to-test label? I can't run the tests locally so this is the only way I can progress.

@adchia
Copy link
Collaborator

adchia commented Nov 4, 2021

/ok-to-test

@judahrand judahrand changed the title Address bugs in ODFV Fix bug where using some Pandas dtypes in the output of an ODFV fails Nov 4, 2021
@judahrand
Copy link
Member Author

This looks good to go to me.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, judahrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817
Copy link
Collaborator

/kind bug

@feast-ci-bot feast-ci-bot merged commit 4d0b50f into feast-dev:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants