Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_online_features on demand transform bug fixes + local integration test mode #2004

Merged
merged 7 commits into from
Nov 5, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Nov 5, 2021

What this PR does / why we need it:
For get_online_features, removing request data (that isn't specified by a request feature view) and odfv dependencies (that aren't otherwise requested) from the online response. It also adds in dependent feature views when specified in odfvs, so users no longer need to specify dependencies in the get_online_features request.

This also adds a rule (make test-python-universal-local) that will run local only integration tests for convenience for devs.

Related issues: #1999 and #1998

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Removes need to specify on demand feature view dependencies in get_online_features

…w) and odfv dependencies (that aren't otherwise requested) from the online response

Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@adchia adchia requested a review from judahrand November 5, 2021 15:44
@adchia adchia changed the title get_online_features on demand transform bug fixes get_online_features on demand transform bug fixes + local integration test mode Nov 5, 2021
@adchia adchia added the kind/bug label Nov 5, 2021
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #2004 (d51de06) into master (600d38e) will decrease coverage by 21.86%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2004       +/-   ##
===========================================
- Coverage   82.21%   60.34%   -21.87%     
===========================================
  Files         100      103        +3     
  Lines        8052     8418      +366     
===========================================
- Hits         6620     5080     -1540     
- Misses       1432     3338     +1906     
Flag Coverage Δ
integrationtests ?
unittests 60.34% <70.83%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 14.06% <20.00%> (-85.41%) ⬇️
sdk/python/feast/feature_store.py 71.18% <75.60%> (-20.13%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 51.85% <100.00%> (-41.74%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-66.91%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600d38e...d51de06. Read the comment docs.

sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants