-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_online_features on demand transform bug fixes + local integration test mode #2004
Conversation
…w) and odfv dependencies (that aren't otherwise requested) from the online response Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
===========================================
- Coverage 82.21% 60.34% -21.87%
===========================================
Files 100 103 +3
Lines 8052 8418 +366
===========================================
- Hits 6620 5080 -1540
- Misses 1432 3338 +1906
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sdk/python/tests/integration/online_store/test_universal_online.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
For get_online_features, removing request data (that isn't specified by a request feature view) and odfv dependencies (that aren't otherwise requested) from the online response. It also adds in dependent feature views when specified in odfvs, so users no longer need to specify dependencies in the get_online_features request.
This also adds a rule (make test-python-universal-local) that will run local only integration tests for convenience for devs.
Related issues: #1999 and #1998
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: