Remove unused protos & deprecated java modules #2061
Conversation
Signed-off-by: pyalex <[email protected]>
pyalex
requested review from
achals,
adchia,
felixwang9817,
tsotnet,
woop and
a team
as code owners
feast-ci-bot
added
size/XXL
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
| @@ -20,7 +20,6 @@ package feast.serving; | |||
|
|
|||
| import "google/protobuf/timestamp.proto"; | |||
| import "feast/types/Value.proto"; | |||
| import "tensorflow_metadata/proto/v0/statistics.proto"; | |||
There was a problem hiding this comment.
I think we can update Makefile and setup.py to remove references to the tensorflow protos. Can we also remove the protos themselves? I was just trying to do that in #2058
There was a problem hiding this comment.
Ah, I saw your PR and I thought you would merge it)
Yeah, we may delete statistics, since there's no need in CoreService either
There was a problem hiding this comment.
I wasn't convinced that we'd be killing CoreService so I punted the PR ;) I can revive it if that's the direction we're taking.
There was a problem hiding this comment.
FYI CoreService.proto is deleted in this PR
There was a problem hiding this comment.
In that case I'll revive my PR and rebase off of this.
Codecov Report
@@ Coverage Diff @@
## master #2061 +/- ##
=======================================
Coverage 58.24% 58.24%
=======================================
Files 100 100
Lines 8080 8080
=======================================
Hits 4706 4706
Misses 3374 3374
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pyalex [email protected]
What this PR does / why we need it:
Deleted parts:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: