Fix java_release workflow by removing step without users/with #2067
Conversation
Signed-off-by: Achal Shah <[email protected]>
achals
requested review from
adchia,
felixwang9817,
tsotnet,
woop and
a team
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah <[email protected]>
| @@ -59,7 +58,7 @@ RegistryFile registryFile(FeastProperties feastProperties, ApplicationContext co | |||
| return new S3RegistryFile(context.getBean(AmazonS3.class), registryPath); | |||
| case "": | |||
| case "file": | |||
| return new LocalRegistryFile(Paths.get(registryPath)); | |||
| return new LocalRegistryFile(registryPath); | |||
There was a problem hiding this comment.
Trying to address this error in java unit tests:
Error: /home/runner/work/feast/feast/java/serving/src/main/java/feast/serving/config/RegistryConfig.java:[62,47] incompatible types: java.nio.file.Path cannot be converted to java.lang.String
There was a problem hiding this comment.
Yeah, this is bug from my PR #2043, have no idea how it passed tests
Codecov Report
@@ Coverage Diff @@
## master #2067 +/- ##
===========================================
+ Coverage 58.21% 83.32% +25.11%
===========================================
Files 100 100
Lines 8077 8078 +1
===========================================
+ Hits 4702 6731 +2029
+ Misses 3375 1347 -2028
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <[email protected]>
| - name: Push image | ||
| run: make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${RELEASE_VERSION} | ||
| env: |
There was a problem hiding this comment.
what the point to duplicate env here?
There was a problem hiding this comment.
The bare env version step up above is breaking the workflow: https://github.com/feast-dev/feast/actions/workflows/java_release.yml
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
This has been broken for a few commits now: https://github.com/feast-dev/feast/actions/workflows/java_release.yml
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: