Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creating-a-custom-provider.md #2070

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

ChaitanyaKN
Copy link
Contributor

@ChaitanyaKN ChaitanyaKN commented Nov 19, 2021

Fix a minor typo in the concluding statement.

Changed - "you should not have" to "you should now have"

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @ChaitanyaKN. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #2070 (3f65f19) into master (1cfc25c) will increase coverage by 25.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2070       +/-   ##
===========================================
+ Coverage   58.80%   84.44%   +25.63%     
===========================================
  Files         101      101               
  Lines        8098     8098               
===========================================
+ Hits         4762     6838     +2076     
+ Misses       3336     1260     -2076     
Flag Coverage Δ
integrationtests 74.39% <ø> (?)
unittests 58.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 61.29% <0.00%> (+0.40%) ⬆️
sdk/python/feast/online_response.py 87.71% <0.00%> (+1.75%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 96.77% <0.00%> (+2.15%) ⬆️
sdk/python/feast/feature.py 90.24% <0.00%> (+4.87%) ⬆️
sdk/python/feast/errors.py 71.11% <0.00%> (+5.18%) ⬆️
sdk/python/feast/infra/provider.py 90.65% <0.00%> (+5.60%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 96.80% <0.00%> (+8.00%) ⬆️
sdk/python/feast/infra/passthrough_provider.py 100.00% <0.00%> (+10.93%) ⬆️
sdk/python/feast/repo_config.py 87.00% <0.00%> (+11.86%) ⬆️
sdk/python/feast/feature_view.py 89.43% <0.00%> (+11.97%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cfc25c...3f65f19. Read the comment docs.

@adchia
Copy link
Collaborator

adchia commented Nov 19, 2021

thanks for catching! Note you'll need to sign your commit as per the checks to push this change

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, ChaitanyaKN, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit a753e73 into feast-dev:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants