-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leaking dynamodb tables in integration tests #2104
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
- Coverage 83.53% 83.48% -0.05%
==========================================
Files 100 100
Lines 8088 8097 +9
==========================================
+ Hits 6756 6760 +4
- Misses 1332 1337 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pyalex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1a34671
to
56714ab
Compare
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex [email protected]
What this PR does / why we need it:
This PR fixes some potential causes for leaking resources during integration tests. Also, it adds more logs in case if more hidden leaks still exist.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: