Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking dynamodb tables in integration tests #2104

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Dec 3, 2021

Signed-off-by: pyalex [email protected]

What this PR does / why we need it:

This PR fixes some potential causes for leaking resources during integration tests. Also, it adds more logs in case if more hidden leaks still exist.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #2104 (0b9b0fc) into master (2d3cea1) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
- Coverage   83.53%   83.48%   -0.05%     
==========================================
  Files         100      100              
  Lines        8088     8097       +9     
==========================================
+ Hits         6756     6760       +4     
- Misses       1332     1337       +5     
Flag Coverage Δ
integrationtests 73.88% <75.00%> (-0.08%) ⬇️
unittests 57.98% <41.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/dynamodb.py 90.90% <75.00%> (-0.76%) ⬇️
...s/integration/registration/test_universal_types.py 98.70% <75.00%> (-1.30%) ⬇️
...thon/feast/infra/offline_stores/bigquery_source.py 79.54% <0.00%> (-2.28%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 84.78% <0.00%> (-0.73%) ⬇️
sdk/python/feast/infra/passthrough_provider.py 100.00% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 98.13% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3cea1...0b9b0fc. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pyalex
To complete the pull request process, please assign felixwang9817 after the PR has been reviewed.
You can assign the PR to them by writing /assign @felixwang9817 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex pyalex changed the title [debug] leaking dynamodb tables Fix leaking dynamodb tables in integration tests Dec 6, 2021
@adchia adchia requested review from felixwang9817 and removed request for adchia December 7, 2021 17:00
@pyalex pyalex merged commit 50f29cd into feast-dev:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants