-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BYTES
and BYTES_LIST
type conversion
#2158
Conversation
Signed-off-by: Judah Rand <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
==========================================
- Coverage 84.60% 84.43% -0.18%
==========================================
Files 101 101
Lines 7968 8099 +131
==========================================
+ Hits 6741 6838 +97
- Misses 1227 1261 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Judah Rand [email protected]
What this PR does / why we need it:
Currently, any
get_online_features
which tries to retrieve aValueType.BYTES
Feature will fail due to an incorrect conversion.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: