-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin boto dependency in setup #2168
Conversation
Hi @fengyu05. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: ZF Deng <[email protected]>
99c8a02
to
aa3245c
Compare
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #2168 +/- ##
==========================================
- Coverage 84.58% 84.57% -0.02%
==========================================
Files 102 102
Lines 8175 8175
==========================================
- Hits 6915 6914 -1
- Misses 1260 1261 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, fengyu05 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The feast[aws] pin boto3 to 1.17.* which create forward compatibles issue.
Removing the pin to undo the issue.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: