Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with java docker building #2178

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

achals
Copy link
Member

@achals achals commented Dec 30, 2021

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:
The docker image build on master is currently broken.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

none

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #2178 (ea55ee2) into master (068389d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2178   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         102      102           
  Lines        8186     8186           
=======================================
  Hits         6925     6925           
  Misses       1261     1261           
Flag Coverage Δ
integrationtests 74.26% <ø> (-0.29%) ⬇️
unittests 59.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068389d...ea55ee2. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 89eb3a5 into feast-dev:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants