Merge feast-snowflake plugin into main repo with documentation

[sfc-gh-madkins]

What this PR does / why we need it:

Allows feast to use Snowflake as an Offline & Online Store

Which issue(s) this PR fixes:

Fixes # NONE

Does this PR introduce a user-facing change?:

Allows usage of Snowflake as an offline store.

[feast-ci-bot]

Hi @sfc-gh-madkins. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sfc-gh-madkins]

/assign @tsotnet

[adchia]

you'll also need to change

feast/sdk/python/tests/integration/feature_repos/repo_configuration.py

Line 71 in 94c780b

IntegrationTestRepoConfig(

+ make a data source creator like

feast/sdk/python/tests/integration/feature_repos/universal/data_sources/redshift.py

Line 25 in 94c780b

self.offline_store_config = RedshiftOfflineStoreConfig(

to include snowflake in the default tests

I setup secrets for this which will be in the environment variables which you can use in tests:

SNOWFLAKE_CI_USER
SNOWFLAKE_CI_PASSWORD
SNOWFLAKE_CI_DEPLOYMENT

[codecov-commenter]

Codecov Report

Merging #2193 (26270bb) into master (2e4f3e5) will decrease coverage by 0.97%.
The diff coverage is 39.39%.

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
- Coverage   59.67%   58.70%   -0.98%     
==========================================
  Files         108      112       +4     
  Lines        9111     9570     +459     
==========================================
+ Hits         5437     5618     +181     
- Misses       3674     3952     +278     

Flag	Coverage Δ
unittests	58.70% <39.39%> (-0.98%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/cli.py	38.65% <ø> (ø)
sdk/python/feast/data_source.py	60.15% <0.00%> (-0.73%)	⬇️
sdk/python/feast/repo_config.py	77.09% <ø> (ø)
...fline_store/test_universal_historical_retrieval.py	23.35% <0.00%> (ø)
sdk/python/feast/infra/utils/snowflake_utils.py	23.36% <23.36%> (ø)
sdk/python/feast/inference.py	60.60% <25.00%> (-1.90%)	⬇️
sdk/python/feast/type_map.py	41.61% <33.33%> (-0.18%)	⬇️
sdk/python/feast/infra/offline_stores/snowflake.py	37.93% <37.93%> (ø)
...hon/feast/infra/offline_stores/snowflake_source.py	50.42% <50.42%> (ø)
.../feature_repos/universal/data_sources/snowflake.py	51.35% <51.35%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4f3e5...26270bb. Read the comment docs.

[sfc-gh-madkins]

@adchia Can you also add secrets for SNOWFLAKE_CI_ROLE & SNOWFLAKE_CI_WAREHOUSE and make sure everything is case sensitive -- most objects created in snowflake are UPPERCASE

The account/user should have a database: FEAST and schema: PUBLIC created

[adchia]

/ok-to-test

[adchia]

@sfc-gh-madkins as mentioned offline, added all the secrets. Let me know when this is ready for another pass (With the datasourcecreator logic all taken cared of)

[adchia]

final few nits!

[adchia]

also you need to sign your commits

[adchia]

To fix the tests, I think you'll need to pass the secrets to the integration-test-python workflows (i.e. in https://github.com/feast-dev/feast/blob/master/.github/workflows/pr_integration_tests.yml and https://github.com/feast-dev/feast/blob/master/.github/workflows/master_only.yml#L1-L1) with something like how we did the GCP secrets (https://github.com/feast-dev/feast/blob/master/.github/workflows/master_only.yml#L89-L89)

[pyalex]

Hi @sfc-gh-madkins, please rebase and run make lock-python-ci-dependencies to resolve these conflicts.
Please also fix the DCO. You can probably squash your commits and sign the resulting one.

[adchia]

bunch of nits

[felixwang9817]

btw @adchia @sfc-gh-madkins the test currently failing is (I think) unrelated to this PR:

FAILED sdk/python/tests/integration/online_store/test_universal_online.py::test_online_store_cleanup[Provider: aws-Redshif-dynamodb]

I've seen this failure in a bunch of other PRs as well (see e.g. some of the integration tests running on master here; I'm not sure yet if Dynamo is just super flaky or if the test is broken - I just tried running this test locally and it also failed with the same error

the test was introduced by @pyalex in #2240, so maybe he might know what's going on

[adchia]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment