-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish renamed java packages to maven central (via Sonatype) #2225
Conversation
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2225 +/- ##
===========================================
- Coverage 84.98% 59.72% -25.26%
===========================================
Files 105 105
Lines 8496 8496
===========================================
- Hits 7220 5074 -2146
- Misses 1276 3422 +2146
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: pyalex <[email protected]>
Signed-off-by: pyalex <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Since we cannot remove artifacts from maven central this PR proposes to rename
feast-sdk
anddatatypes-java
artifacts intofeast-serving-client
andfeast-datatypes
to avoid conflicts with higher versions of artifacts that were already uploaded.This PR also cleans up global dependencies (spring is removed completely) and refactors projects structure to avoid publishing unnecessary artifacts (like
common
orparent
).Which issue(s) this PR fixes:
Fixes #2218
Does this PR introduce a user-facing change?: