Feature server helm chart produces invalid YAML #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pyalex <[email protected]>
pyalex
added
do-not-merge/release-note-label-needed
kind/bug
and removed
size/XS
release-note-none
labels
pyalex
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Signed-off-by: pyalex <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2234 +/- ##
==========================================
+ Coverage 84.92% 84.93% +0.01%
==========================================
Files 105 105
Lines 8498 8498
==========================================
+ Hits 7217 7218 +1
+ Misses 1281 1280 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pyalex
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: pyalex [email protected]
What this PR does / why we need it:
Helm install fails on feature-server helm chart.
Which issue(s) this PR fixes:
Fixes #2232
Does this PR introduce a user-facing change?: