Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feature_store._apply_diffs to handle registry and infra diffs #2238

Merged
merged 7 commits into from
Jan 27, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR modifies FeatureStore to execute feast apply logic by applying the appropriate RegistryDiff and InfraDiff generated from FeatureStore._plan. Right now, this logic is only activated for the local provider.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

feast plan works:
$ feast plan
Unchanged entity driver_id
Unchanged feature view driver_hourly_stats

Unchanged sqlite table adjusted_raven_driver_hourly_stats

sdk/python/feast/diff/FcoDiff.py Outdated Show resolved Hide resolved
sdk/python/feast/feature_store.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #2238 (52b13aa) into master (88fac8b) will decrease coverage by 22.91%.
The diff coverage is 39.06%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2238       +/-   ##
===========================================
- Coverage   85.43%   62.52%   -22.92%     
===========================================
  Files         108      108               
  Lines        9021     8634      -387     
===========================================
- Hits         7707     5398     -2309     
- Misses       1314     3236     +1922     
Flag Coverage Δ
integrationtests ?
unittests 62.52% <39.06%> (+2.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/diff/infra_diff.py 78.20% <0.00%> (-10.21%) ⬇️
...thon/feast/infra/offline_stores/redshift_source.py 46.21% <0.00%> (-37.72%) ⬇️
sdk/python/feast/infra/utils/aws_utils.py 29.57% <0.00%> (-55.93%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 45.71% <ø> (-48.58%) ⬇️
...fline_store/test_universal_historical_retrieval.py 100.00% <ø> (ø)
.../integration/online_store/test_online_retrieval.py 100.00% <ø> (ø)
.../integration/online_store/test_universal_online.py 100.00% <ø> (+2.30%) ⬆️
.../python/tests/integration/registration/test_cli.py 55.78% <0.00%> (-43.54%) ⬇️
...s/integration/registration/test_universal_types.py 35.89% <ø> (-62.86%) ⬇️
sdk/python/feast/repo_operations.py 54.59% <21.05%> (+1.90%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fac8b...52b13aa. Read the comment docs.

@felixwang9817 felixwang9817 changed the title Implement feature_store._apply_diffs to handle registry and infra diffs [WIP] Implement feature_store._apply_diffs to handle registry and infra diffs Jan 27, 2022
@felixwang9817 felixwang9817 changed the title [WIP] Implement feature_store._apply_diffs to handle registry and infra diffs [draft] Implement feature_store._apply_diffs to handle registry and infra diffs Jan 27, 2022
@felixwang9817 felixwang9817 changed the title [draft] Implement feature_store._apply_diffs to handle registry and infra diffs Implement feature_store._apply_diffs to handle registry and infra diffs Jan 27, 2022
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 7bff5ed into feast-dev:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants