-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement feature_store._apply_diffs to handle registry and infra diffs #2238
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2238 +/- ##
===========================================
- Coverage 85.43% 62.52% -22.92%
===========================================
Files 108 108
Lines 9021 8634 -387
===========================================
- Hits 7707 5398 -2309
- Misses 1314 3236 +1922
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
49cecab
to
d266c54
Compare
52b13aa
to
d266c54
Compare
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
d266c54
to
49c52fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: This PR modifies
FeatureStore
to executefeast apply
logic by applying the appropriateRegistryDiff
andInfraDiff
generated fromFeatureStore._plan
. Right now, this logic is only activated for the local provider.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: