-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Snowflake docs #2270
Fix Snowflake docs #2270
Conversation
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2270 +/- ##
===========================================
- Coverage 85.98% 58.59% -27.39%
===========================================
Files 116 116
Lines 9809 9809
===========================================
- Hits 8434 5748 -2686
- Misses 1375 4061 +2686
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang [email protected]
What this PR does / why we need it: This PR fixes the Snowflake docs to accurately reflect the fact that Snowflake is being used as an offline store, and not an online store.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: