-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish alternative python package with FEAST_USAGE=False by default #2275
Publish alternative python package with FEAST_USAGE=False by default #2275
Conversation
Signed-off-by: pyalex <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2275 +/- ##
=======================================
Coverage 86.01% 86.01%
=======================================
Files 116 116
Lines 9809 9810 +1
=======================================
+ Hits 8437 8438 +1
Misses 1372 1372
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey, I know I'm late to the party but I'm trying install this no telemetry version but I don't know how/where to find it on PyPi (I don't see any mention of it in the docs, nor can I find a version on PyPi) |
Signed-off-by: pyalex [email protected]
What this PR does / why we need it:
There will be two python packages
feast
andfeast-no-telemetry
. The last one will haveFEAST_USAGE
set to False by default.To minimize maintenance costs as much as possible I solved this issue on the last possible stage - GH workflow job.
Which issue(s) this PR fixes:
Fixes #2235
Does this PR introduce a user-facing change?: