Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Delete properties #2338

Merged
merged 7 commits into from
Feb 25, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR deletes unnecessary properties, and instead makes the attributes public.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <[email protected]>
@felixwang9817 felixwang9817 requested a review from a team as a code owner February 24, 2022 23:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #2338 (dc31782) into master (412d625) will decrease coverage by 27.92%.
The diff coverage is 69.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2338       +/-   ##
===========================================
- Coverage   86.33%   58.41%   -27.93%     
===========================================
  Files         116      116               
  Lines        9886     9673      -213     
===========================================
- Hits         8535     5650     -2885     
- Misses       1351     4023     +2672     
Flag Coverage Δ
integrationtests ?
unittests 58.41% <69.86%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thon/feast/infra/offline_stores/bigquery_source.py 44.55% <0.00%> (-42.37%) ⬇️
...thon/feast/infra/offline_stores/redshift_source.py 48.11% <0.00%> (-38.50%) ⬇️
...hon/feast/infra/offline_stores/snowflake_source.py 49.55% <0.00%> (-38.68%) ⬇️
sdk/python/feast/data_source.py 54.33% <63.63%> (-6.23%) ⬇️
sdk/python/feast/feature_service.py 63.63% <93.33%> (-24.33%) ⬇️
sdk/python/feast/entity.py 90.47% <94.11%> (+1.58%) ⬆️
sdk/python/feast/base_feature_view.py 57.50% <100.00%> (-21.45%) ⬇️
...k/python/feast/infra/offline_stores/file_source.py 82.29% <100.00%> (-6.93%) ⬇️
sdk/python/feast/registry.py 67.71% <100.00%> (-18.29%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412d625...dc31782. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 57d1343 into feast-dev:master Feb 25, 2022
adchia pushed a commit that referenced this pull request Mar 4, 2022
* Delete properties from FeatureService

Signed-off-by: Felix Wang <[email protected]>

* Delete properties from Entity

Signed-off-by: Felix Wang <[email protected]>

* Delete properties from BaseFeatureView

Signed-off-by: Felix Wang <[email protected]>

* Delete properties from DataSource

Signed-off-by: Felix Wang <[email protected]>

* Delete properties from RequestDataSource, KafkaSource, KafkaOptions, KinesisSource, KinesisOptions

Signed-off-by: Felix Wang <[email protected]>

* Delete unused properties for FileSource, BigQuerySource, RedshiftSource, SnowflakeSource

Signed-off-by: Felix Wang <[email protected]>

* Fix FileOptions error

Signed-off-by: Felix Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants