-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Capping the dask dependency since Dask dropped Python 3.7 support #2342
Conversation
…Python 3.7 Signed-off-by: Danny Chiao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
==========================================
+ Coverage 86.39% 86.40% +0.01%
==========================================
Files 116 116
Lines 9670 9673 +3
==========================================
+ Hits 8354 8358 +4
+ Misses 1316 1315 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -40,7 +40,7 @@ | |||
REQUIRES_PYTHON = ">=3.7.0" | |||
|
|||
REQUIRED = [ | |||
"Click==8.*", | |||
"Click>=7.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this necessary for the same reason (python 3.7 support)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah no this was just a fix i wanted to sneak in from a previous PR because it seemed overly restrictive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg. stamping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
See dask/dask#8572 which dropped Python 3.7 support in Dask for the last 2 releases.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: