Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Capping the dask dependency since Dask dropped Python 3.7 support #2342

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Feb 26, 2022

What this PR does / why we need it:
See dask/dask#8572 which dropped Python 3.7 support in Dask for the last 2 releases.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@adchia adchia requested a review from a team as a code owner February 26, 2022 22:31
@adchia adchia requested review from woop and removed request for a team February 26, 2022 22:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #2342 (e67f0f6) into master (57d1343) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2342      +/-   ##
==========================================
+ Coverage   86.39%   86.40%   +0.01%     
==========================================
  Files         116      116              
  Lines        9670     9673       +3     
==========================================
+ Hits         8354     8358       +4     
+ Misses       1316     1315       -1     
Flag Coverage Δ
integrationtests 75.32% <ø> (-0.18%) ⬇️
unittests 58.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/datastore.py 90.52% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d1343...e67f0f6. Read the comment docs.

@@ -40,7 +40,7 @@
REQUIRES_PYTHON = ">=3.7.0"

REQUIRED = [
"Click==8.*",
"Click>=7.*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this necessary for the same reason (python 3.7 support)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no this was just a fix i wanted to sneak in from a previous PR because it seemed overly restrictive

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg. stamping.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adchia @achals I think this was a typo as pip actually interprets this as click==7.*. See #2450

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 4e47686 into feast-dev:master Feb 28, 2022
@adchia adchia deleted the fixDaskDependency branch March 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants