Fix tracing to continue from existing trace created by grpc client #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradithya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removal of storage specs
Add import job metrics configuration Update jaeger tracing configuration for serving
…gConfig to resolve circular dependency
Following how stable postgresql chart specifies it https://github.com/helm/charts/blob/master/stable/postgresql/values.yaml
Check against the ImportSpec.Type value (kafka or pubsub) instead of PipelineOptions.Streaming (the streaming status cannot be reliably determined at pipeline creation stage)
|
/lgtm |
|
/retest |
|
/test unit-test-cli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main purpose of this PR is to fix jaeger tracing behavior where currently it will start a new trace instead of continuing trace created by client.
Changes: