Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Preserve ordering of features in _get_column_names #2457

Merged
merged 5 commits into from
Apr 4, 2022
Merged

fix: Preserve ordering of features in _get_column_names #2457

merged 5 commits into from
Apr 4, 2022

Commits on Mar 31, 2022

  1. Preserve ordering of features in _get_column_names

    @mavysavydav
    mavysavydav committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    ae19b2f View commit details
    Browse the repository at this point in the history

  2. Correction + unit test 

    Signed-off-by: David Y Liu <[email protected]>
    @mavysavydav
    mavysavydav committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    2e179d0 View commit details
    Browse the repository at this point in the history

  3. lint corrections 

    Signed-off-by: David Y Liu <[email protected]>
    @mavysavydav
    mavysavydav committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    d50151a View commit details
    Browse the repository at this point in the history

  4. correction 

    Signed-off-by: David Y Liu <[email protected]>
    @mavysavydav
    mavysavydav committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    e49b324 View commit details
    Browse the repository at this point in the history

  5. my 'make lint' seems to work differently than the ones in the PR test… 

    …s. Reverting lint changes

Signed-off-by: David Y Liu <[email protected]>
    @mavysavydav
    mavysavydav committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    363113d View commit details
    Browse the repository at this point in the history