Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Backward compatibility for test repo configurations #2671

Merged
merged 3 commits into from
May 12, 2022

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented May 11, 2022

Signed-off-by: Oleksii Moskalenko [email protected]

What this PR does / why we need it:

Convert previous format for setting up test environments (via creating FULL_REPO_CONFIGS) into AVAILABLE_ONLINE_STORES and AVAILABLE_OFFLINE_STORES required by current integration tests.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Oleksii Moskalenko <[email protected]>
AVAILABLE_ONLINE_STORES = getattr(module, "AVAILABLE_ONLINE_STORES")
AVAILABLE_OFFLINE_STORES = getattr(module, "AVAILABLE_OFFLINE_STORES")
except Exception as e:
except ImportError as e:
raise FeastModuleImportError(
"FULL_REPO_CONFIGS", full_repo_configs_module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the order of these params is flipped?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Signed-off-by: Oleksii Moskalenko <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #2671 (66327dd) into master (ab78702) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2671      +/-   ##
==========================================
+ Coverage   81.15%   81.24%   +0.08%     
==========================================
  Files         166      166              
  Lines       13801    14697     +896     
==========================================
+ Hits        11200    11940     +740     
- Misses       2601     2757     +156     
Flag Coverage Δ
integrationtests 72.46% <0.00%> (+0.48%) ⬆️
unittests 58.81% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 87.56% <0.00%> (-4.48%) ⬇️
sdk/python/feast/ui_server.py 23.33% <0.00%> (-7.71%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
sdk/python/feast/diff/registry_diff.py 66.43% <0.00%> (-3.94%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.65% <0.00%> (-0.87%) ⬇️
...fline_store/test_universal_historical_retrieval.py 100.00% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 95.47% <0.00%> (+0.25%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 95.70% <0.00%> (+0.42%) ⬆️
sdk/python/feast/feature_store.py 89.18% <0.00%> (+0.51%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78702...66327dd. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 32c38aa into feast-dev:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants