-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Backward compatibility for test repo configurations #2671
chore: Backward compatibility for test repo configurations #2671
Conversation
Signed-off-by: Oleksii Moskalenko <[email protected]>
Signed-off-by: Oleksii Moskalenko <[email protected]>
AVAILABLE_ONLINE_STORES = getattr(module, "AVAILABLE_ONLINE_STORES") | ||
AVAILABLE_OFFLINE_STORES = getattr(module, "AVAILABLE_OFFLINE_STORES") | ||
except Exception as e: | ||
except ImportError as e: | ||
raise FeastModuleImportError( | ||
"FULL_REPO_CONFIGS", full_repo_configs_module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the order of these params is flipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Signed-off-by: Oleksii Moskalenko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2671 +/- ##
==========================================
+ Coverage 81.15% 81.24% +0.08%
==========================================
Files 166 166
Lines 13801 14697 +896
==========================================
+ Hits 11200 11940 +740
- Misses 2601 2757 +156
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksii Moskalenko [email protected]
What this PR does / why we need it:
Convert previous format for setting up test environments (via creating
FULL_REPO_CONFIGS
) intoAVAILABLE_ONLINE_STORES
andAVAILABLE_OFFLINE_STORES
required by current integration tests.Which issue(s) this PR fixes:
Fixes #