chore: Deprecate value type #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you describe what that bug was? |
Codecov Report
@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
+ Coverage 80.19% 80.23% +0.03%
==========================================
Files 167 167
Lines 14021 14108 +87
==========================================
+ Hits 11244 11319 +75
- Misses 2777 2789 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
felixwang9817
force-pushed
the
deprecate_value_type
branch
from
e648d29
to
9b5ae96
Compare
felixwang9817
changed the title
felixwang9817
force-pushed
the
deprecate_value_type
branch
2 times, most recently
from
13ff480
to
aa48f4b
Compare
felixwang9817
changed the title
adchia
reviewed
May 13, 2022
| @@ -129,14 +129,15 @@ def __init__( | |||
| owner (optional): The owner of the feature view, typically the email of the | |||
| primary maintainer. | |||
| schema (optional): The schema of the feature view, including feature, timestamp, | |||
| and entity columns. | |||
| and entity columns. If entity columns are included in the schema, a List[Entity] | |||
| must be passed to `entities` instead of a List[str]; otherwise, the entity columns | |||
There was a problem hiding this comment.
Not the worst, but seems like we should able to avoid this for users by doing some entity name lookup no? Or is the idea that entity names are no longer unique
pyalex
approved these changes
May 16, 2022
|
/lgtm |
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
…_type` Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
felixwang9817
force-pushed
the
deprecate_value_type
branch
from
0eff01b
to
6c4e9d6
Compare
|
/lgtm |
Signed-off-by: Felix Wang <[email protected]>
achals
reviewed
May 18, 2022
sdk/python/feast/entity.py
Outdated
| warnings.warn( | ||
| ( | ||
| "The `value_type` parameter is being deprecated. Instead, the type of an entity " | ||
| "should be specified as a Field in the schema of a feature view. Feast 0.22 and " |
sdk/python/feast/feature_view.py
Outdated
| warnings.warn( | ||
| ( | ||
| "The `entities` parameter should be a list of `Entity` objects. " | ||
| "Feast 0.22 and onwards will not support passing in a list of " |
sdk/python/feast/feature_view.py
Outdated
| warnings.warn( | ||
| ( | ||
| "The `entities` parameter should be a list of `Entity` objects. " | ||
| "Feast 0.22 and onwards will not support passing in a list of " |
Signed-off-by: Felix Wang <[email protected]>
achals
approved these changes
May 18, 2022
sdk/python/feast/entity.py
Outdated
| warnings.warn( | ||
| ( | ||
| "The `value_type` parameter is being deprecated. Instead, the type of an entity " | ||
| "should be specified as a Field in the schema of a feature view. Feast 0.22 and " |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: #2611 was reverted due to a bug. Specifically,
FeatureView.__eq__was missing a comparison of theentity_columnsattribute. InRegistry.apply_feature_view, we do not apply a feature view if it is equal to an existing feature view. The error occurred since the Java feature repo has aregistry.dbfile that has already been populated with feature views; the new method of entity inference added some information to theentity_columnsattribute, but since that attribute was not compared in the equality check,Registry.apply_feature_viewnever persisted the new feature view. This led to the downstream failure. This PR fixes that bug.Which issue(s) this PR fixes:
Fixes #