Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feast Helm charts and build script #289

Merged
merged 12 commits into from
Nov 9, 2019
Merged

Feast Helm charts and build script #289

merged 12 commits into from
Nov 9, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented Nov 5, 2019 •
edited
Loading

This pull request provides updates to the Helm chart used to install Feast using Helm.
It also updates the Dockerfiles used to build Feast Core and Serving.
Currently it assumes the version to be 0.3.0-alpha.1.

Steps to test this chart can be seen in README.md in infra/charts/feast folder.

helm repo add feast-charts https://feast-charts.storage.googleapis.com
helm repo update

RELEASE_NAME=test
helm install feast-charts/feast --name $RELEASE_NAME --version 0.3.0-alpha.1 \
 -f https://raw.githubusercontent.com/davidheryanto/feast/feast-infra-helm-charts/infra/charts/feast/values-demo.yaml

Current build is based on this commit sha afc4308

@davidheryanto
Update Dockerfiles for core and serving for Feast 0.3
e0f2d61
@davidheryanto
Add example job store options for Redis in application.yaml
6f92dbd
@davidheryanto
Add script to publish feast helm chart
e458014
@davidheryanto
Update default jvm options in CMD instruction in Feast Core Dockerfile
f7630bb
@davidheryanto
Update installation path of grpc-health-probe in Feast serving Docker…
cb8432a 
…file
@davidheryanto
Update feast charts for installing Feast with Helm
d80f70d 
- Refer to README.md for more details how feast chart is structured and how to use it
- Feast Core and Feast Serving are subcharts that the parent Feast chart uses to install Feast. These subcharts optionally contains other dependencies such as Kafka, Postgresql or Redis. All these components can be enabled/disabled using the enabled flag in the Helm values.
@davidheryanto
Copy link
Collaborator Author

/retest

woop
woop approved these changes Nov 5, 2019
View reviewed changes
infra/charts/feast/values-external-store.yaml
@@ -0,0 +1,5 @@
# TODO @dheryanto
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we perhaps exclude these? Dont see value in adding this.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Nov 6, 2019

https://raw.githubusercontent.com/davidheryanto/feast/feast-infra-helm-charts/infra/charts/feast/values-demo.yaml

Is this available also from /gojek/feast? or only from your repo?

@woop woop mentioned this pull request Nov 6, 2019
Closed
@davidheryanto
Copy link
Collaborator Author

https://raw.githubusercontent.com/davidheryanto/feast/feast-infra-helm-charts/infra/charts/feast/values-demo.yaml

Is this available also from /gojek/feast? or only from your repo?

Yes it will be available in this path:
FEAST_REPO/infra/charts/feast/value-demo.yaml when it is merged to 0.3-dev

@davidheryanto
Copy link
Collaborator Author

/hold
Missing sample configuration for production

@davidheryanto
Update configmap.yaml for feast core
3164687 
Override bootstrapServer value only if kafka is enabled and kafka.external is disabled
@davidheryanto
Update configmap template for feast-serving
cff362a 
Support overriding Redis store host with LoadBalancer IP
@davidheryanto
Set lower default delay time for readiness probes
e89d0d5 
- So pod scaling and startup is faster
- In most cases, Core and Feast should not need more than 15 seconds to start up
@davidheryanto
Update Dockerfile for Feast Core
9ba7c90 
Include exploded/unpacked jar in the production image
To be used when staging files when submitting Dataflow jobs
@davidheryanto
Merge branch '0.3-dev' into feast-infra-helm-charts
f2cc20e
@davidheryanto
Allow users to specify nodePort in Helm values
c6010bd
@davidheryanto
Copy link
Collaborator Author

/hold cancel
Current chart is tested and ok in dev environment

@woop
Copy link
Member

woop commented Nov 9, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit d8cf0ad into feast-dev:0.3-dev Nov 9, 2019
@woop woop mentioned this pull request Nov 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop approved these changes

@pradithya pradithya Awaiting requested review from pradithya

@thirteen37 thirteen37 Awaiting requested review from thirteen37

@tims tims Awaiting requested review from tims

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@woop woop

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidheryanto @feast-ci-bot @woop