Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix release workflow #3144

Merged
merged 4 commits into from
Aug 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ jobs:
version_without_prefix: ${{ steps.get_release_version_without_prefix.outputs.version_without_prefix }}
highest_semver_tag: ${{ steps.get_highest_semver.outputs.highest_semver_tag }}
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false
- name: Get release version
id: get_release_version
run: echo ::set-output name=release_version::${GITHUB_REF#refs/*/}
Expand All @@ -38,6 +41,7 @@ jobs:
echo ::set-output name=highest_semver_tag::$(get_tag_release -m)
fi
- name: Check output
id: check_output
env:
RELEASE_VERSION: ${{ steps.get_release_version.outputs.release_version }}
VERSION_WITHOUT_PREFIX: ${{ steps.get_release_version_without_prefix.outputs.version_without_prefix }}
Expand Down
61 changes: 31 additions & 30 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,40 +42,41 @@ jobs:
echo "Current version is ${CURRENT_VERSION}"
echo "Next version is ${NEXT_VERSION}"
# publish-web-ui-npm:
# if: github.repository == 'feast-dev/feast'
# needs: get_dry_release_versions
# runs-on: ubuntu-latest
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
# NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
# steps:
# - uses: actions/checkout@v2
# - uses: actions/setup-node@v2
# with:
# node-version: '17.x'
# registry-url: 'https://registry.npmjs.org'
# - name: Bump file versions (temporarily for Web UI publish)
# run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
# - name: Install yarn dependencies
# working-directory: ./ui
# run: yarn install
# - name: Build yarn rollup
# working-directory: ./ui
# run: yarn build:lib
# - name: Publish UI package
# working-directory: ./ui
# run: npm publish
# env:
# # This publish is working using an NPM automation token to bypass 2FA
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
publish-web-ui-npm:
if: github.repository == 'feast-dev/feast'
needs: get_dry_release_versions
runs-on: ubuntu-latest
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '17.x'
registry-url: 'https://registry.npmjs.org'
- name: Bump file versions (temporarily for Web UI publish)
run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
- name: Install yarn dependencies
working-directory: ./ui
run: yarn install
- name: Build yarn rollup
working-directory: ./ui
run: yarn build:lib
- name: Publish UI package
if: github.event.inputs.dry_run == 'false'
working-directory: ./ui
run: npm publish
env:
# This publish is working using an NPM automation token to bypass 2FA
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

release:
name: release
runs-on: ubuntu-latest
#needs: publish-web-ui-npm
needs: publish-web-ui-npm
env:
GITHUB_TOKEN: ${{ github.event.inputs.token }}
GIT_AUTHOR_NAME: feast-ci-bot
Expand Down
2 changes: 1 addition & 1 deletion infra/scripts/helm/validate-helm-chart-versions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -e

# Amount of file locations that need to be bumped in unison when versions increment
UNIQUE_VERSIONS_COUNT=20
UNIQUE_VERSIONS_COUNT=21 # Change in release 0.24.0

if [ $# -ne 1 ]; then
echo "Please provide a single semver version (without a \"v\" prefix) to test the repository against, e.g 0.99.0"
Expand Down