Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Cleanup running Feast in production, fix links, call out Slack more #3163

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 31, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Base: 67.10% // Head: 76.13% // Increases project coverage by +9.02% 🎉

Coverage data is based on head (9844681) compared to base (bf6e7f4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
+ Coverage   67.10%   76.13%   +9.02%     
==========================================
  Files         175      211      +36     
  Lines       15903    17854    +1951     
==========================================
+ Hits        10672    13593    +2921     
+ Misses       5231     4261     -970     
Flag Coverage Δ
integrationtests 66.93% <ø> (-0.17%) ⬇️
unittests 58.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/feast/infra/materialization/snowflake_engine.py 92.13% <0.00%> (-0.46%) ⬇️
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
...line_stores/contrib/athena_offline_store/athena.py 38.50% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
.../online_stores/contrib/hbase_repo_configuration.py 100.00% <0.00%> (ø)
...s/contrib/spark_offline_store/tests/data_source.py 40.74% <0.00%> (ø)
...b/cassandra_online_store/cassandra_online_store.py 40.00% <0.00%> (ø)
...ores/contrib/trino_offline_store/trino_type_map.py 6.66% <0.00%> (ø)
...s/contrib/trino_offline_store/connectors/upload.py 8.97% <0.00%> (ø)
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
... and 99 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d7b0c52 into feast-dev:master Sep 1, 2022
adchia added a commit that referenced this pull request Sep 1, 2022
…more (#3163)

* docs: Cleanup running Feast in production, fix links, and call out Slack more

Signed-off-by: Danny Chiao <[email protected]>

* fix title

Signed-off-by: Danny Chiao <[email protected]>

* fix title

Signed-off-by: Danny Chiao <[email protected]>

* remove workshop

Signed-off-by: Danny Chiao <[email protected]>

* remove toc

Signed-off-by: Danny Chiao <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>
@adchia adchia deleted the docsFixes branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants