Add unit test in Redis to return values with no max age set

[smadarasmi]

Two things:

1. Fixed the path in serving config to point to redis store config
2. There was a bug in RedisServingService when checking for equality to default Duration. I was adding the bug fix to my Cassandra serving branch but now I saw that it has already been fixed. However, the unit test was not catching that bug, so I thought we should still have this unit test. Unit test did not catch the bug because it EntityRow and FeatureRow time specified was the same in the test so those features are never stale.

[feast-ci-bot]

Hi @smadarasmi. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[woop]

Thanks @smadarasmi !

for (1), just to be sure: Does this not depend on your working directory when executing serving? I havent run into this problem before while using that configuration file.

for (2), this is great, thanks!

[smadarasmi]

@woop for (1), I was thinking about that too. This issue happens to me always when I run mvn --pl serving spring-boot:run from the FEAST_HOME directory.

Do you perhaps not get the error because you have set this env variable: FEAST_STORE_CONFIG_PATH?
config-path: ${FEAST_STORE_CONFIG_PATH:serving/sample_redis_config.yml}

[smadarasmi]

Just for my information, how do you usually run it? I get issue from both running mvn --pl serving spring-boot:run and when running ServingApplication from Intellij.

[woop]

/ok-to-test

[woop]

Just for my information, how do you usually run it? I get issue from both running mvn --pl serving spring-boot:run and when running ServingApplication from Intellij.

It's not infront of me, but I believe I am running it with serving/ as the working directory. I guess that is why it passes.

@davidheryanto can you have a look here?

[smadarasmi]

/retest

[woop]

/lgtm

[woop]

/approve

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smadarasmi, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [woop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment