Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply billing project when infer schema #3417

Conversation

sudohainguyen
Copy link
Collaborator

What this PR does / why we need it: Avoid making extra cost on a non-billing project id when applying feature views

Which issue(s) this PR fixes:

Fixes #3416

@sudohainguyen sudohainguyen changed the title Fix: apply billing project when inference Fix: Apply billing project when inference Dec 27, 2022
@sudohainguyen sudohainguyen changed the title Fix: Apply billing project when inference Fix: Apply billing project when infer schema Dec 27, 2022
@sudohainguyen sudohainguyen force-pushed the fix/apply_billing_project_when_inference branch from 284fab5 to 5e47e89 Compare December 27, 2022 16:01
@sudohainguyen sudohainguyen changed the title Fix: Apply billing project when infer schema fix: Apply billing project when infer schema Dec 27, 2022
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, sudohainguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sudohainguyen
Copy link
Collaborator Author

hi @achals would you mind checking the failed test case? It said
google.api_core.exceptions.ResourceExhausted: 429 Quota exceeded for quota metric 'Table metadata write requests' and limit 'Table metadata write requests per minute per user' of service 'bigtableadmin.googleapis.com' for consumer 'project_number:883187091528'. [reason: "RATE_LIMIT_EXCEEDED"

@feast-ci-bot feast-ci-bot merged commit 4f9ad7e into feast-dev:master Dec 28, 2022
@sudohainguyen sudohainguyen deleted the fix/apply_billing_project_when_inference branch December 28, 2022 03:47
felixwang9817 pushed a commit that referenced this pull request Jan 3, 2023
# [0.28.0](v0.27.0...v0.28.0) (2023-01-03)

### Bug Fixes

* Apply billing project when infer schema ([#3417](#3417)) ([4f9ad7e](4f9ad7e))
* Assertion condition when value is 0 ([#3401](#3401)) ([98a24a3](98a24a3))
* Enable registry caching in SQL Registry ([#3395](#3395)) ([2e57376](2e57376))
* Fix bug where SQL registry was incorrectly writing infra config around online stores ([#3394](#3394)) ([6bcf77c](6bcf77c))
* Get all columns with describe table method from RedshiftData-api ([#3377](#3377)) ([fd97254](fd97254))
* ODFV able to handle boolean pandas type ([#3384](#3384)) ([8f242e6](8f242e6))
* Remove PySpark dependency from Snowflake Offline Store ([#3388](#3388)) ([7b160c7](7b160c7))
* Specifies timeout in exception polling ([#3398](#3398)) ([c0ca7e4](c0ca7e4))
* Update import logic to remove `pyspark` dependency from Snowflake Offline Store ([#3397](#3397)) ([cf073e6](cf073e6))

### Features

* Add template for Github Codespaces ([#3421](#3421)) ([41c0537](41c0537))
* Adds description attribute for features/fields ([#3425](#3425)) ([26f4881](26f4881))
* Snowflake skip materialization if no table change ([#3404](#3404)) ([0ab3942](0ab3942))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job to infer schema from BigQuerySource with query not running on billing project id
3 participants