Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports GRPC call metrics and Feast resource metrics in Core #345

Merged
merged 6 commits into from
Dec 4, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented Dec 4, 2019

This pull request adds the following Prometheus metrics to Feast Core:

These metrics can be used to monitor:

  • stability and performance of Feast Core, for example by monitoring the latency, traffic, error and saturation via the histogram values of feast_core_request_latency_seconds.
  • usage of Feast by counting the of Feature Sets and Stores registered in Feast.

Example how Feast Core dashboard can look like:
Screenshot from 2019-12-04 15-36-44

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Collaborator Author

davidheryanto commented Dec 4, 2019

/hold
I want to export memory (and perhaps CPU) usage of the JVM too.

@davidheryanto
Copy link
Collaborator Author

/hold cancel

@zhilingc
Copy link
Collaborator

zhilingc commented Dec 4, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit a53e06b into feast-dev:master Dec 4, 2019
@davidheryanto davidheryanto deleted the feast-core-metrics branch December 4, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants