-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Dragonfly as an online-store option to Feast Readme and docs #3647
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yirenlu92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hey @adchia just wanted to ping you on this...any changes needed to get this docs update merged? Thanks in advance |
Hey! Sorry for the delay. Looks like you manually modified the README, but actually you should be using |
ec7dc02
to
63c4847
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it for you.
/lgtm
Signed-off-by: Danny C <[email protected]>
Signed-off-by: Danny C <[email protected]>
Signed-off-by: Danny C <[email protected]>
Signed-off-by: Danny C <[email protected]>
63c4847
to
471dba0
Compare
i'll cut a release soon and then it'll show up! |
Got it, thank you sooo much! |
feast-dev#3647) * Add dragonfly to feast Readme and docs Signed-off-by: Danny C <[email protected]> * Remove new lines Signed-off-by: Danny C <[email protected]> * Remove more newlines Signed-off-by: Danny C <[email protected]> * rebase and fix using template generation Signed-off-by: Danny C <[email protected]> --------- Signed-off-by: Danny C <[email protected]> Co-authored-by: Danny C <[email protected]>
feast-dev#3647) * Add dragonfly to feast Readme and docs Signed-off-by: Danny C <[email protected]> * Remove new lines Signed-off-by: Danny C <[email protected]> * Remove more newlines Signed-off-by: Danny C <[email protected]> * rebase and fix using template generation Signed-off-by: Danny C <[email protected]> --------- Signed-off-by: Danny C <[email protected]> Co-authored-by: Danny C <[email protected]>
feast-dev#3647) * Add dragonfly to feast Readme and docs Signed-off-by: Danny C <[email protected]> * Remove new lines Signed-off-by: Danny C <[email protected]> * Remove more newlines Signed-off-by: Danny C <[email protected]> * rebase and fix using template generation Signed-off-by: Danny C <[email protected]> --------- Signed-off-by: Danny C <[email protected]> Co-authored-by: Danny C <[email protected]> Signed-off-by: Attila Toth <[email protected]>
What this PR does / why we need it:
Adds Dragonfly (drop in Redis replacement as an online-store option)
Which issue(s) this PR fixes:
Fixes #