Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<docs>(concepts): change data types to upper case because lower case … #389

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

david30907d
Copy link
Contributor

…would fail when you want to apply this FeatureSet

I'm not sure this PR is appropriate or not, but the data types on README would fail when i'm trying to create my own FeatureSet. I'm thinking about maybe putting the real data types on doc?

…would fail when you want to apply this FeatureSet
@feast-ci-bot
Copy link
Collaborator

Hi @david30907d. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhilingc
Copy link
Collaborator

Thanks for updating the docs!

@zhilingc
Copy link
Collaborator

/lgtm

@zhilingc
Copy link
Collaborator

/retest

@zhilingc
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david30907d, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 51cbdc7 into feast-dev:master Dec 24, 2019
@david30907d david30907d deleted the fix-types-on-readme branch December 24, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants