-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Nexus staging plugin for deployment #394
Conversation
d3250a7
to
ac26889
Compare
@khorshuheng looks good. Is this mergeable or should we be waiting for more commits? |
This can be merged safely, as the deploy to maven process has not been automated. The only impact of merging this would be, since i add the javadoc generation plugin, PR that has faulty Javadoc annotation will fail the tests (throw exception during package step). With this PR one can deploy the snapshot version to OSSHR easily, using There are a few things which i still need to check further, but i don't mind having them in separate PR:
|
1ca027f
to
4c81fe5
Compare
4c81fe5
to
24ff54d
Compare
@woop @davidheryanto Deployed snapshot 0.3.6 to sonatype and dependency is resolved successfully on a new Java project:
|
/lgtm |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khorshuheng, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Use Nexus staging plugin for deployment (#394) * Use Nexus staging pluging for deployment * Fix Javadoc error * Hard coded parent version as variable substitution is not supported * Introduce datatypes/java module for proto generation Rather than the Maven protobuf plugin running on the same symlinked definitions in several Java modules, localize this process into one module that the others depend on. This provides a single module that can be depended on by third-party extensions with the bare minimum of dependencies. Also removes proto files that are no longer used. * Java SDK release script (#406) * Use back revision variable in pom.xml So user or CI system can easily override revision from external sources such as Git tag name * Add flatten maven plugin This plugin is useful during deployment so the final pom is resolved without parent dependency, i.e. we do not necessarily need to upload parent library * Increase versions for maven source,javadoc,spotless plugins So it has newer features and more fixes * Add gpg-plugin needed to sign releases * Use oss configure for flatten plugin, add developers info in pom.xml (required for releasing library * Add publish-java-sdk script * Add more logs to publish-java-sdk.sh * Add ProwJob publish-java-sdk * Use GPG_KEY_IMPORT_DIR variable * Update revision in pom.xml to 0.4.2-SNAPSHOT * Publish datatypes/java along with sdk/java Co-authored-by: Khor Shu Heng <[email protected]> Co-authored-by: David Heryanto <[email protected]>
I have added Nexus Staging Plugin for deployment to Maven central, and also change the group id to dev.feast, and Java sdk client artifact id to feast-sdk.
This is a work in progress. Have tested snapshot deployment, but have not tested it by importing the sdk into a new Java project.