-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Omit bytewax deps and materialization engine #4098
Conversation
7d41845
to
c7088ea
Compare
Signed-off-by: Harry <[email protected]>
c7088ea
to
96d8930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@sudohainguyen why are you removing bytewax? Is there any issue or RFC explaining reasons behind this decision? |
There are 2 main reasons:
as a result, we see it is safe to remove bytewax 😄 hope this helps |
@breno-costa see #4087 for a replacement that Harry pointed to. The discussions around the topic started out here #3993 and then continued on slack and community calls, so unfortunately no single place to see it all. |
@tokoko any chance you can compile a quick doc with the decision just so we can add it as a note somewhere? Even a paragraph in the community notes would probably be sufficient. |
@franciscojavierarceo let me handle it |
@sudohainguyen thank you! |
@sudohainguyen @tokoko Thanks for clarifying that point. We wanted to try a more scalable materialization engine and bytewax would be our first candidate. Let us try this new k8s implementation. |
What this PR does / why we need it:
After the successful merge of PR #4087, this PR aims to remove Bytewax entirely, including its dependencies and materialization engine. This is crucial for unblocking efforts to support Python 3.11 as outlined in #4046.
Additional notes
Next action is to remove related docs and compose the new k8s engine doc