Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Omit bytewax deps and materialization engine #4098

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

sudohainguyen
Copy link
Collaborator

@sudohainguyen sudohainguyen commented Apr 12, 2024

What this PR does / why we need it:

After the successful merge of PR #4087, this PR aims to remove Bytewax entirely, including its dependencies and materialization engine. This is crucial for unblocking efforts to support Python 3.11 as outlined in #4046.

Additional notes

Next action is to remove related docs and compose the new k8s engine doc

@sudohainguyen sudohainguyen requested review from franciscojavierarceo and removed request for whoahbot April 12, 2024 02:25
@sudohainguyen sudohainguyen force-pushed the bytewax-prune branch 2 times, most recently from 7d41845 to c7088ea Compare April 12, 2024 02:29
@sudohainguyen sudohainguyen changed the title fix: Prune bytewax dependencies chore: Omit bytewax deps and materialization engine Apr 12, 2024
Copy link
Collaborator

@HaoXuAI HaoXuAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@breno-costa
Copy link
Contributor

@sudohainguyen why are you removing bytewax? Is there any issue or RFC explaining reasons behind this decision?

@sudohainguyen
Copy link
Collaborator Author

sudohainguyen commented Apr 15, 2024

@sudohainguyen why are you removing bytewax? Is there any issue or RFC explaining reasons behind this decision?

There are 2 main reasons:

  • the current version of bytewax we're using is blocking us from supporting python 3.11
  • we're not leveraging all features of bytewax: if you look at bytewax engine implementation, it is simply a kubernetes job with multiple of parallel pods reading files separately and writing data to the online store, which is powered by pyarrow zero-copy mechanism, so we decided to re-write the engine called k8s engine which remains the logic but without bytewax interface.

as a result, we see it is safe to remove bytewax 😄 hope this helps

@tokoko
Copy link
Collaborator

tokoko commented Apr 15, 2024

@breno-costa see #4087 for a replacement that Harry pointed to. The discussions around the topic started out here #3993 and then continued on slack and community calls, so unfortunately no single place to see it all.

@franciscojavierarceo
Copy link
Member

@tokoko any chance you can compile a quick doc with the decision just so we can add it as a note somewhere? Even a paragraph in the community notes would probably be sufficient.

@sudohainguyen
Copy link
Collaborator Author

@franciscojavierarceo let me handle it

@franciscojavierarceo
Copy link
Member

@sudohainguyen thank you!

@breno-costa
Copy link
Contributor

breno-costa commented Apr 16, 2024

@sudohainguyen @tokoko Thanks for clarifying that point. We wanted to try a more scalable materialization engine and bytewax would be our first candidate. Let us try this new k8s implementation.

@HaoXuAI HaoXuAI merged commit 77c78aa into feast-dev:master Apr 17, 2024
26 checks passed
@sudohainguyen sudohainguyen deleted the bytewax-prune branch April 18, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants