-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Adding example of RHOAI feast quick start guide #4564
docs: Adding example of RHOAI feast quick start guide #4564
Conversation
Signed-off-by: Lokesh Rangineni <[email protected]>
I miss the RHOAI part of the example. I think we can run the same notebook as-is even from a local repo, right? |
Yes, this notebook can be run on it is own on the local. Initial expectation is only to provide basics of feast without pipelines. |
Adding the missed link in the index page of root examples directory. Signed-off-by: Lokesh Rangineni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but still the RHOAI part is pending. Please clarify in the PR description if you plan to add further, more specific content.
I am planning to add another example with RHOAI pipelines and feast. The initial scope is only focused on basics of feast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad to see that we have a notebook example. I feel like some of the "why" is missing, and I think this may stem from the data itself. The data is auto-generated and has little meaning.
"import subprocess\n", | ||
"\n", | ||
"# Run feast serve in the background\n", | ||
"feast_remote_registry_server_process = subprocess.Popen([\"feast\", \"serve_registry\"])\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cell didn't run for me. I got a "ModuleNotFound" error for grpc. Once I ran pip install grpcio
, then it worked. This probably needs to be added to the top of the notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit surprised why you had to install it separately. I assumed it will be part of feast dependencies but anyway added this dependency now. PTAL.
is this PR ready for review? |
Added more details about RHOAI platform and reference to the documentation. Incorporated other minor comments. Signed-off-by: Lokesh Rangineni <[email protected]>
@dandawg - Please take a look at the PR again, I have incorporated your code review comments. |
"tags": [] | ||
}, | ||
"source": [ | ||
"### Starting feast online sever" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"### Starting feast online sever" | |
"### Starting feast online feature server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cd87562
into
feast-dev:master
What this PR does / why we need it:
Adding example of RHOAI feast quick start guide
Which issue(s) this PR fixes:
Misc