-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create initial structure of Feast Go Operator #4596
feat: Create initial structure of Feast Go Operator #4596
Conversation
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
infra/feast-operator/README.md
Outdated
// TODO(user): Add simple overview of use/purpose | ||
|
||
## Description | ||
// TODO(user): An in-depth paragraph about your project and overview of use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchughesiv probably should update this but can be in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tks, done
infra/feast-operator/README.md
Outdated
**Build and push your image to the location specified by `IMG`:** | ||
|
||
```sh | ||
make docker-build docker-push IMG=<some-registry>/feast-operator:tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been moved to the contribution section of the README and i've improved this "deploy" section.
infra/feast-operator/README.md
Outdated
**Deploy the Manager to the cluster with the image specified by `IMG`:** | ||
|
||
```sh | ||
make deploy IMG=<some-registry>/feast-operator:tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
infra/feast-operator/README.md
Outdated
``` | ||
|
||
## Contributing | ||
// TODO(user): Add detailed information on how you would like others to contribute to this project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably link to existing documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
images: | ||
- name: controller | ||
newName: feastdev/feast-operator | ||
newTag: 0.40.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the latest feast release? if so it should be https://github.com/feast-dev/feast/releases/tag/v0.40.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newTag: 0.40.0 | |
newTag: 0.40.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits that can be addressed in a follow up PR (or this one if you can)
# To re-generate a bundle for another specific version without changing the standard setup, you can: | ||
# - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2) | ||
# - use environment variables to overwrite this value (e.g export VERSION=0.0.2) | ||
VERSION ?= 0.40.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERSION ?= 0.40.0 | |
VERSION ?= 0.40.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should stay 0.40.0
because the master
is still set to that version. only the release branch has been incremented to 0.40.1
. we'll want to match the branch versioning ... same as the ui, helm chart, images, etc. the operator will be tied into the release versioning scripting, just like everything else
createdAt: "2024-10-02T20:24:54Z" | ||
operators.operatorframework.io/builder: operator-sdk-v1.37.0 | ||
operators.operatorframework.io/project_layout: go.kubebuilder.io/v4 | ||
name: feast-operator.v0.40.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: feast-operator.v0.40.0 | |
name: feast-operator.v0.40.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
- --leader-elect | ||
command: | ||
- /manager | ||
image: feastdev/feast-operator:0.40.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: feastdev/feast-operator:0.40.0 | |
image: feastdev/feast-operator:0.40.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
provider: | ||
name: Feast Community | ||
url: https://lf-aidata.atlassian.net/wiki/spaces/FEAST/ | ||
version: 0.40.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 0.40.0 | |
version: 0.40.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, let's fix the latest version first.
Signed-off-by: Tommy Hughes <[email protected]>
7a781ad
to
8f2c15f
Compare
What this PR does / why we need it:
This PR lays the groundwork for what's being proposed in the Go Operator RFC.
Which issue(s) this PR fixes:
Related to #4561