Fix typo in split string length check #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhilingc
requested review from
davidheryanto,
khorshuheng,
pradithya and
woop
as code owners
zhilingc
force-pushed
the
java-sdk-remove-version
branch
from
568e5fa
to
483ca73
Compare
woop
approved these changes
Feb 7, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Feb 14, 2020
Merged
khorshuheng
pushed a commit
that referenced
this pull request
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes bug where not supplying versions while using the java sdk throws an error
Which issue(s) this PR fixes:
Fixes #460
Does this PR introduce a user-facing change?: