Apply default project to rows without project during ingestion #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woop
reviewed
May 18, 2020
ingestion/src/test/java/feast/ingestion/transform/ProcessAndValidateFeatureRowsTest.java
Show resolved
Hide resolved
|
/lgtm |
zhilingc
force-pushed
the
jobs-default-project
branch
from
b2e1c45
to
b2ff681
Compare
woop
approved these changes
May 19, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop, zhilingc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Extension to #693. Feast Core deploys Feast ingestion jobs with a parameter that sets its default project. This default project is just a string (using “default” for now).
When a FeatureRow is read from Kafka with with a complete feature set reference (
project/feature_set) then it is processed as normal. However, when a FeatureRow is read in with a feature set reference missing project (justfeatureset), then Feast Ingestion prepends the default project string to this reference.Does this PR introduce a user-facing change?: