-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag regex in tf file #73
Conversation
/assign woop |
/lgtm |
/lgtm cancel |
/hold I find this base64encoded regex disturbing, can you explain the requirement for it? |
see #72 |
it's just unreadable is all.. I was wondering why it's a regex at all and it's just because our build feels weird. /hold cancel |
/lgtm |
Think we should just remove the variable and add the regex (in Base64) inline. |
Resolved, please have a look |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradithya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #72