Merge Redis cluster connector with Redis connector #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
woop
reviewed
May 28, 2020
...e/connectors/redis/src/main/java/feast/storage/connectors/redis/writer/RedisFeatureSink.java
Show resolved
Hide resolved
woop
changed the title
styling handle null case styling
pyalex
force-pushed
the
consolidate-redis-stores
branch
from
8cc5357
to
8816c01
Compare
|
/test test-end-to-end-batch |
|
/lgtm |
woop
approved these changes
May 28, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
khorshuheng
pushed a commit
to khorshuheng/feast
that referenced
this pull request
Jun 5, 2020
styling handle null case styling
khorshuheng
pushed a commit
that referenced
this pull request
Jun 5, 2020
styling handle null case styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Huge part of redis-cluster storage code was just copy-pasted from redis. In order to simplify further development we need to consolidate those storages.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: No